Fix/3678 overloaded query constraints #3723
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3723 +/- ##
==========================================
- Coverage 90.22% 90.21% -0.02%
==========================================
Files 114 114
Lines 7461 7491 +30
==========================================
+ Hits 6732 6758 +26
- Misses 729 733 +4
Continue to review full report at Codecov.
|
flovilmart
force-pushed
the
fix/3678-overloaded-query-constraints
branch
from
4bbbb8d to
b5592ed
Compare
acinader
approved these changes
Apr 23, 2017
src/RestQuery.js
Outdated
| let hasDirectConstraint = false; | ||
| let hasOperatorConstraint = false; | ||
| for (const key in constraint) { | ||
| if (key.indexOf('$') != 0) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3678
Having 2 constraints on the same key when a pointer is set will yield an odd where constraint:
this PR transforms the constraint to:
In order to be correctly processed.
We should also probably investigate why this happens in the 1st place, the JS SDK handles this in a very odd way.